[MITgcm-devel] [MITgcm-cvs] MITgcm/pkg/rbcs CVS Commit

[Jean-Michel Campin]

Hi Gael,

The 2nd version is really different (I had a hard time to figure out
why it was called "spin" with a relaxation that was increasing 
with time ...) and makes sense.
It's good for me.

Cheers,
Jean-Michel

On Fri, May 20, 2011 at 08:49:37PM -0400, Gael Forget wrote:
> Sorry for that. I evidently went too fast.
> Is my fix checkin good enough?
> Otherwise I can remove it.
> Cheers,
> Gael
> 
> On May 20, 2011, at 8:13 PM, Jean-Michel Campin wrote:
> 
> > Hi Gael,
> > 
> > I have problems with this modification:
> > 1) I have no idea where this ALLOW_RBCS_SPIN is supposed to be 
> >   turn on/off. It's not the only CPP option in this case, but
> >   it does not make it less annoying.
> > 2) This piece of code makes the model unconditionally unstable after
> >   some time. And I don't like this. 
> >   The minimum would be to stop (with an error msg) before 
> >   NaN pops up in the solution.
> > 
> > I would like, either
> > - to change this so that it stay stable (with a Max ?).
> > or
> > - to remove this piece.
> > 
> > Cheers,
> > Jean-Michel
> > 
> > On Fri, May 20, 2011 at 06:26:37PM -0400, Gael Forget wrote:
> >> Update of /u/gcmpack/MITgcm/pkg/rbcs
> >> In directory baudelaire:/srv/scratch/gforget/MITgcm/pkg/rbcs
> >> 
> >> Modified Files:
> >> 	rbcs_add_tendency.F 
> >> Log Message:
> >> introduce ALLOW_RBCS_SPIN to allow a decrease
> >> to zero of the relaxation strength over the first 3 years
> >> 
> >> 
> >> _______________________________________________
> >> MITgcm-cvs mailing list
> >> MITgcm-cvs at mitgcm.org
> >> http://mitgcm.org/mailman/listinfo/mitgcm-cvs
> > 
> > _______________________________________________
> > MITgcm-devel mailing list
> > MITgcm-devel at mitgcm.org
> > http://mitgcm.org/mailman/listinfo/mitgcm-devel
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel