[MITgcm-devel] [hdail at MIT.EDU: OBCS bug?]

[Martin Losch]

Hi Holly,
thanks, I'll remove this block.

maybe more for Patrick: I found this in ctrl.h
cgg  This caused a lot of confusion.
#ifdef ALLOW_OBCS_CONTROL
      common /controlvars_r_obcs/
     &                        tmpfldxz
     &                      , tmpfldxz2
     &                      , tmpfldyz
     &                      , tmpfldyz2

      _RL tmpfldxz  (1-olx:snx+olx,nr,nsx,nsy)
      _RL tmpfldxz2 (1-olx:snx+olx,nr,nsx,nsy)
      _RL tmpfldyz  (1-oly:sny+oly,nr,nsx,nsy)
      _RL tmpfldyz2 (1-oly:sny+oly,nr,nsx,nsy)
#endif

As far as I can see, these fields do not need to be global files, but could be defined locally in all of the routines that use them, as far as I can see, these are:
cost_obcsvol.F
ctrl_getobcse.F
ctrl_getobcsw.F
ctrl_getobcsn.F
ctrl_getobcss.F
ctrl_obcsvol.F
ctrl_volflux.F
ecco_cost_init_barfiles.F
grdchk_getadxx.F
grdchk_get_obcs_mask.F
grdchk_getxx.F
grdchk_setxx.F

I assume that the gobal files have only been introduced either for convenience or for some histical reasons. What do you think?

Martin


On Mar 4, 2011, at 3:51 AM, Holly Dail wrote:

> I finally got around to testing this, and found that for my setup, I get the same results with and without this code.  I believe it can be safely deleted.
> 
> Holly
> 
> 
> 
> On Mar 1, 2011, at Mar 1 , 9:09 AM, Patrick Heimbach wrote:
> 
>> 
>> Hi there,
>> 
>> looks indeed like this initialization is benign, and actually doesn't belong there.
>> This block is from way back, could be that there used to be additional piece of
>> code which since has been (re-)moved.
>> 
>> -Patrick
>> 
>> On Mar 1, 2011, at 7:57 AM, Martin Losch wrote:
>> 
>>> Hi Holly,
>>> 
>>> I do not think that this will really cause any difficulties (in the adjoint), but I you could quickly run a test (tomorrow), that would be great, then I'll fix this.
>>> 
>>> Martin
>>> 
>>> On Mar 1, 2011, at 1:54 PM, Holly Dail wrote:
>>> 
>>>> Hi there -
>>>> 
>>>> To be honest I noticed the problem when reading the code, but haven't tested the two versions independently.  Too busy today, but I can run a comparison test tomorrow, if that's needed.
>>>> 
>>>> Holly
>>>> 
>>>> 
>>>> On Mar 1, 2011, at Mar 1 , 2:27 AM, Martin Losch wrote:
>>>> 
>>>>> Hi,
>>>>> 
>>>>> I think that this should be fixed, although it's just an initialization.
>>>>> 
>>>>> Holly, do you see any differences when you use this part of the code?
>>>>> 
>>>>> Martin
>>>>> 
>>>>> On Feb 28, 2011, at 10:00 PM, Matthew Mazloff wrote:
>>>>> 
>>>>>> Hi,
>>>>>> 
>>>>>> Yup, I guess that proves this piece of code isn't needed.  Otherwise, if people want it, then that should be changed to ALLOW_OBCS_CONTROL
>>>>>> 
>>>>>> -Matt
>>>>>> 
>>>>>> 
>>>>>> On Feb 28, 2011, at 12:25 PM, Jean-Michel Campin wrote:
>>>>>> 
>>>>>>> Hi Holly,
>>>>>>> I fwd to devel list, since I don't know much about this one.
>>>>>>> Thanks,
>>>>>>> Jean-Michel
>>>>>>> 
>>>>>>> ----- Forwarded message from Holly Dail <hdail at MIT.EDU> -----
>>>>>>> 
>>>>>>> From: Holly Dail <hdail at MIT.EDU>
>>>>>>> Date: Mon, 28 Feb 2011 13:02:29 -0500
>>>>>>> Subject: OBCS bug?
>>>>>>> To: Jean-Michel Campin <jmc at ocean.mit.edu>
>>>>>>> 
>>>>>>> Hi Jean-Michel
>>>>>>> 
>>>>>>> Just noticed an oddity in the code ... there is only 1 place in the entire code base using
>>>>>>> 
>>>>>>> #ifdef OBCS_CONTROL
>>>>>>> 
>>>>>>> Everywhere else its ALLOW_OBCS_CONTROL.  Unless those two are somehow equivalent, maybe this piece of code isn't getting run?  The file is ecco_cost_init_barfiles.F in the ecco pkg.
>>>>>>> 
>>>>>>> Thanks -
>>>>>>> Holly
>>>>>>> ----- End forwarded message -----
>>>>>>> 
>>>>>>> _______________________________________________
>>>>>>> MITgcm-devel mailing list
>>>>>>> MITgcm-devel at mitgcm.org
>>>>>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>>>>>> 
>>>>>> 
>>>>>> _______________________________________________
>>>>>> MITgcm-devel mailing list
>>>>>> MITgcm-devel at mitgcm.org
>>>>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>>>>> 
>>>>> 
>>>>> _______________________________________________
>>>>> MITgcm-devel mailing list
>>>>> MITgcm-devel at mitgcm.org
>>>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>>>> 
>>>> 
>>>> _______________________________________________
>>>> MITgcm-devel mailing list
>>>> MITgcm-devel at mitgcm.org
>>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>>> 
>>> 
>>> _______________________________________________
>>> MITgcm-devel mailing list
>>> MITgcm-devel at mitgcm.org
>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>> 
>> ---
>> Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
>> MIT | EAPS 54-1518 | 77 Massachusetts Ave | Cambridge MA 02139 USA
>> FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach
>> 
>> 
>> 
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel