[MITgcm-devel] [hdail at MIT.EDU: OBCS bug?]

[Martin Losch]

Hi Holly,

I do not think that this will really cause any difficulties (in the adjoint), but I you could quickly run a test (tomorrow), that would be great, then I'll fix this.

Martin

On Mar 1, 2011, at 1:54 PM, Holly Dail wrote:

> Hi there -
> 
> To be honest I noticed the problem when reading the code, but haven't tested the two versions independently.  Too busy today, but I can run a comparison test tomorrow, if that's needed.
> 
> Holly
> 
> 
> On Mar 1, 2011, at Mar 1 , 2:27 AM, Martin Losch wrote:
> 
>> Hi,
>> 
>> I think that this should be fixed, although it's just an initialization.
>> 
>> Holly, do you see any differences when you use this part of the code?
>> 
>> Martin
>> 
>> On Feb 28, 2011, at 10:00 PM, Matthew Mazloff wrote:
>> 
>>> Hi,
>>> 
>>> Yup, I guess that proves this piece of code isn't needed.  Otherwise, if people want it, then that should be changed to ALLOW_OBCS_CONTROL
>>> 
>>> -Matt
>>> 
>>> 
>>> On Feb 28, 2011, at 12:25 PM, Jean-Michel Campin wrote:
>>> 
>>>> Hi Holly,
>>>> I fwd to devel list, since I don't know much about this one.
>>>> Thanks,
>>>> Jean-Michel
>>>> 
>>>> ----- Forwarded message from Holly Dail <hdail at MIT.EDU> -----
>>>> 
>>>> From: Holly Dail <hdail at MIT.EDU>
>>>> Date: Mon, 28 Feb 2011 13:02:29 -0500
>>>> Subject: OBCS bug?
>>>> To: Jean-Michel Campin <jmc at ocean.mit.edu>
>>>> 
>>>> Hi Jean-Michel
>>>> 
>>>> Just noticed an oddity in the code ... there is only 1 place in the entire code base using
>>>> 
>>>> #ifdef OBCS_CONTROL
>>>> 
>>>> Everywhere else its ALLOW_OBCS_CONTROL.  Unless those two are somehow equivalent, maybe this piece of code isn't getting run?  The file is ecco_cost_init_barfiles.F in the ecco pkg.
>>>> 
>>>> Thanks -
>>>> Holly
>>>> ----- End forwarded message -----
>>>> 
>>>> _______________________________________________
>>>> MITgcm-devel mailing list
>>>> MITgcm-devel at mitgcm.org
>>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>>> 
>>> 
>>> _______________________________________________
>>> MITgcm-devel mailing list
>>> MITgcm-devel at mitgcm.org
>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>> 
>> 
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel