[MITgcm-devel] [MITgcm-cvs] MITgcm/pkg/seaice CVS Commit

[Martin Losch]

Hi Jean-Michel,

I guess the TAF error was fixed by Patrick (it ran all OK for me, I don't understand what happened), lines were too long (thanks, Patrick).

I do not know why the gradient of global_ocean.cs32x15.seaice changed, again, for my platform it was all OK. Only three experiments seem to be affected: lab_sea, lab_sea.evp (which I assume is very unstable) and global_ocean.cs32x15.seaice (also on faulks). I changed a little bit of storage: instead of
CADJ STORE tice, ....
we now have
CADJ STORE tice(:,:,bi,bj)
(and similar for tices) in analogy to all other STORE directives. This means that in the adjoint code we no longer have code that copies 4D arrays within the bi/bj-loops. I can imagine that can have an effect on the numerical precision (although it shouldn't). In Ian's code (FENTY_AREA_EXPANSION_CONTRACTION) I added 3 lines:
d_AREAbyATM(I,J) = 0. _d 0
d_AREAbyICE(I,J) = 0. _d 0
d_AREAbyOCN(I,J) = 0. _d 0
but that part of the code is not tested in global_ocean.cs32x15.seaice nor lab_sea, as far as I can see. The other stuff I did (contracted two #ifdfe's into one) is not tested either. 

I'll have a closer look later.

Martin


On mitgcm.org/testing/results I see on beaudelaire for gfortran:
> run: ./testreport -adm -a jmc at mitgcm.org -match 13 -of=../tools/build_options/linux_amd64_gfortran+mpi_generic -MPI 6 -command 'mpirun -np TR_NPROC ./mitgcmuv_ad'

> Fri Jul 15 02:47:14 EDT 2011
> Y Y Y Y 16>12<FAIL  global_ocean.cs32x15.seaice
> Y Y Y Y 16>16<pass  lab_sea
> Y Y Y Y 16>12<FAIL  lab_sea.evp
and
> Sun Jul 17 02:46:03 EDT 2011

> Y Y Y Y 16>10<FAIL  global_ocean.cs32x15.seaice
> Y Y Y Y 16>13<pass  lab_sea
> Y Y Y Y 16>12<FAIL  lab_sea.evp

for 
> Fri Jul 15 01:03:19 EDT 2011
> run: ./testreport -adm -a jmc at mitgcm.org -match 13 -of=../tools/build_options/linux_amd64_gfortran
> Y Y Y Y 16>16<pass  global_ocean.cs32x15.seaice
> Y Y Y Y 16>16<pass  lab_sea
> Y Y Y Y 16>16<pass  lab_sea.evp
and
> Sun Jul 17 01:03:23 EDT 2011
> Y Y Y Y 16>10<FAIL  global_ocean.cs32x15.seaice
> Y Y Y Y 16>13<pass  lab_sea
> Y Y Y Y 16>12<FAIL  lab_sea.evp




> On Jul 16, 2011, at 2:42 PM, Jean-Michel Campin wrote:


> Hi Martin,
> 
> Looks like there is a problem in the changes you made in seaice_growth.F:
> TAF returns an error for lab_sea experiment (all last night AD lab_sea tests 
> I loooked at failed). 
> 
> The gradient of global_ocean.cs32x15.seaice also changed (from 16.digits
> to only 10 on ref. platform=baudelaire+gfortran) so that it's now
> returnning a "FAIL". Was it expected ? Do we need to update
> output_adm.seaice.txt ?
> 
> Cheers,
> Jean-Michel
> 
> On Fri, Jul 15, 2011 at 09:01:07AM -0400, Martin Losch wrote:
>> Update of /u/gcmpack/MITgcm/pkg/seaice
>> In directory forge:/tmp/cvs-serv6974/pkg/seaice
>> 
>> Modified Files:
>> 	seaice_growth.F 
>> Log Message:
>>  - fix recomputation with FENTY_AREA_EXPANSION_CONTRACTION code,
>>    remove then obsolete STORE directives
>>  - fix STORE directives for tice and tices, so that only the
>>    appropriate part of the fields are stored (and not the entire
>>    field)
>>  - cosmetic changes: adjust CPP flags and indentation for better
>>    legibilty
>> 
>> 
>> _______________________________________________
>> MITgcm-cvs mailing list
>> MITgcm-cvs at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-cvs
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel

Martin Losch
Martin.Losch at awi.de