[MITgcm-devel] [MITgcm-cvs] MITgcm/pkg/obcs CVS Commit

[Jean-Michel Campin]

Hi Martin,

1) regarding OBCS_BALANCE documentation, I can try to update the text
in the coming weeks. There is one thing I suggest to change in the
text you added, regarding dome exp: 
DOME - Dynamics of Overflow Mixing and Entrainment
http://www.rsmas.miami.edu/personal/tamay/DOME/dome.html
(it's not exactly like the Danemark Strait Overflow Pb).

2) I think it's worth to fix what Oliver mentionned, and I would
also change U(3:4,34) & U(3:4,1) to just U(3,34) & U(3,1)
since this is what is done in obcs_apply_uv.F

3) I've tried to change obcs_apply_uv.F, to apply OBC in 2 steps:
C     first tangential component ; then normal component.
C     This ensures that the normal component is set correctly even
C     when it conficts with tangential setting from an other OB.
And this does change the output of exp. seaice_obcs (?)

I am still tempted to check-in this modif, because it's more
important to get the normal flow right (for tracer advection,
+ the pressure solver discard normal flow (ini_cg2d)),
and even more important to know what OBC is imposed.

Also, right now, the OBCS_BALANCE is only considering normal velocity,
and this will not work for seaice_obcs where in some places,
normal velocity component is overwitten by tangential
velocity component. This 2 steps approach would fix that.

Any objection ?

Cheers,
Jean-Michel

On Mon, Feb 28, 2011 at 11:34:06AM -0500, Oliver Jahn wrote:
> Hi Martin,
>
> while you are at it... this should be V(3,34) and V(3,2), right?
> Or am i missing something?
>
> OB_Jnorth(3)=34 means that:
>   T( 3 ,34) is a an OB point
>   U(3:4,34) is a an OB point
>   V( 4 ,34) is a an OB point
>
> OB_Jsouth(3)=1 means that:
>   T( 3 ,1) is a an OB point
>   U(3:4,1) is a an OB point
>   V( 4 ,2) is a an OB point
>
> Oliver
>
>
> On 02/28/2011 10:42 AM, Martin Losch wrote:
>> Hi Jean-Michel,
>>
>>   this is now really different from what I just added this morning (o:
>>
>> Do you still want me to document this? I can give it a try, but you'll probably have to fix it afterwards.
>>
>> Martin
>>
>> On Feb 28, 2011, at 4:30 PM, Jean-Michel Campin wrote:
>>
>>> Update of /u/gcmpack/MITgcm/pkg/obcs
>>> In directory forge:/tmp/cvs-serv23903
>>>
>>> Modified Files:
>>> 	obcs_calc.F
>>> Added Files:
>>> 	obcs_balance_flow.F
>>> Log Message:
>>> - take OBCS_BALANCE code out of obcs_calc.F into new S/R: OBCS_BALANCE_FLOW:
>>> - fix to OBCS_BALANCE code (right hFac ; deal with simple OB intersection).
>>> - change default: balance the Net inflow through all OB (instead of balancing
>>>   each OB separately); keep the old method if setting OBC_balanceFac<  0.
>>>
>>>
>>> _______________________________________________
>>> MITgcm-cvs mailing list
>>> MITgcm-cvs at mitgcm.org
>>> http://mitgcm.org/mailman/listinfo/mitgcm-cvs
>>
>>
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel