[MITgcm-devel] [MITgcm-cvs] MITgcm/verification/lab_sea/run CVS Commit

[Patrick Heimbach]

Hi Dimitris,

I'd prefer if you don't implement suggestions, as I don't have an overview
of current scripts (e.g. extracting last for chars for iteration numbers).
In any case, it does have a well-defined prefix, "costfunction", doesn't it.

And you shouldn't be worrying about this as it's not really
related for your purpose of merging Ian's code.

Cheers
-Patrick

On Feb 23, 2011, at 8:19 PM, Menemenlis, Dimitris (3248) wrote:

> Done.
> 
> Patrick, do you want me to implement JM's suggestion,
> i.e., add ".txt" at the end of  "costfunction0000" and
> "costfunction_seaice0000" or leave as is?
> I do not want to unwittingly impact downstream scripts
> that may not expect the ".txt".
> 
> D.
> 
> On Feb 23, 2011, at 3:42 PM, Jean-Michel Campin wrote:
> 
>> Dimitris,
>> 
>>> Do you want me to undo this change?
>> I would prefer. The "better" way to fix this would be
>> to change the cost S/R to produce output file with a "well defined"
>> suffix or prefix (e.g. *.txt) so that this would be easy
>> to list in .cvsignore
>> 
>> Cheers,
>> Jean-Michel
>> 
>> On Wed, Feb 23, 2011 at 02:22:09PM -0800, Menemenlis, Dimitris (3248) wrote:
>>> Jean-Michel, you are correct, the check-in description has nothing to
>>> do with the .cvsignore changes.  I tried to sneak in this change without
>>> you noticing it, buried within other changes ... but obviously I failed :-(
>>> These files are created by the adjoint verification tests.
>>> I only run the seaice-related adjoint tests in lab_sea and and 
>>> offline_exf_seaice.  I assume that similar files would also be
>>> created in other adjoint tests but I don't know for sure.
>>> 
>>> Do you want me to undo this change?
>>> 
>>> D.
>>> 
>>> On Feb 23, 2011, at 2:11 PM, Jean-Michel Campin wrote:
>>> 
>>>> Hi Dimitris,
>>>> 
>>>> I am not in favor of your 2 ".cvsignore" changes in:
>>>>> verification/lab_sea/run
>>>> and 
>>>>> verification/offline_exf_seaice/run
>>>> because we try to use the same ".cvsignore" accross all "run" dir
>>>> so that it's simpler to maintain. 
>>>> Now I can see why you want to add those files in the list, 
>>>> but what about other run dir which are also used for AD test ?
>>>> 
>>>> And just for confirmation: the check-in description message has nothing
>>>> to do with the changes, right ?
>>>> 
>>>> Cheers,
>>>> Jean-Michel
> 
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel

---
Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
MIT | EAPS 54-1518 | 77 Massachusetts Ave | Cambridge MA 02139 USA
FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach