[MITgcm-devel] [MITgcm-cvs] MITgcm/pkg/seaice CVS Commit

[Jean-Michel Campin]

Hi Gael,

I have 2 comments related to your changes:
1) this new option (SEAICE_HEAT_CONSERV_FIX) should be added
   (#undef ?) to pkg/seaice/SEAICE_OPTION.h
2) The "SDIAG#" diagnostics are not supposed to be used in
  the main code, and were not before this check-in. 
  If those diagnostics (SDIAG5 & SDIAG6) are useful, they should 
  be added the clean way (with a tile). 
  If they are not useful, should not be there.
  And the same remark applies to the "UDIAG#" you added in seaice_advdiff.F
  and seaice_tracer_phys.F 

Cheers,
Jean-Michel

On Thu, Dec 15, 2011 at 05:30:17PM -0500, Gael Forget wrote:
> Update of /u/gcmpack/MITgcm/pkg/seaice
> In directory baudelaire:/srv/scratch/gforget/MITgcm/pkg/seaice
> 
> Modified Files:
> 	seaice_growth.F 
> Log Message:
> 
> - fix heat conservation of the coupled ocean-seaice system.
>   (some polishing is still needed but this should do it for now)
> 
> 
> 
> _______________________________________________
> MITgcm-cvs mailing list
> MITgcm-cvs at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-cvs