[MITgcm-devel] startdate passing to cost_generic

[Matthew Mazloff]

Hello

It appears there may be a bug in the code with regards to the  
startdate passed in the costfunction.  This happens for several calls.

What happens is, for example for daily SST  (line 83 of cost_hydr.F)  
modelstartdate is passed when it should be the start date of the  
observation (sststartdate):

#elif (defined (ALLOW_DAILYSST_COST_CONTRIBUTION))
c
       write(msgbuf,'(a)') 'ph-cost call cost_sst'
       call print_message( msgbuf, standardmessageunit,
      &     SQUEEZE_RIGHT , mythid)
       nnzbar = 1
       nnzobs = 1
       nrecloc = ndaysrec
       spminloc = -2.
       spmaxloc = 40.
       spzeroloc = 0.
       localperiod = 86400.
       call cost_generic(
      &     nnzbar, sstbarfile, sstbar, xx_sstbar_mean_dummy,
      &     nnzobs, sstdatfile, mult_sst,
      &     nrecloc, modelstartdate, localperiod,
      &     'C', wsst,
      &     spminloc, spmaxloc, spzeroloc,
      &     objf_sst, num_sst,
      &     myiter, mytime, mythid )
cph      call cost_sst   ( myiter, mytime, mythid )
#endif

Thus the model always assumes the observation file starts the same  
time as the model...

Is this a bug -- or am I missing something?

-Matt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mitgcm.org/pipermail/mitgcm-devel/attachments/20110811/eb551f10/attachment.htm>