[MITgcm-devel] inconsistencies with density conversion

[Jean-Michel Campin]

Ian,

This is expected to go into seaice_check.F, like, e.g.:
> C--   SEAICE_OLD_AND_BAD_DISCRETIZATION is obsolete: issue warning and stop.
> #ifdef SEAICE_OLD_AND_BAD_DISCRETIZATION
...

Cheers,
Jean-Michel

On Wed, Apr 27, 2011 at 11:02:25AM -0700, Ian Fenty wrote:
> Devel,
> 
> On Apr 27, 2011, at 6:56 AM, Jean-Michel Campin wrote:
> 
> > b) renaming things can be done now.
> > The treatment of "retired parameters" in seaice-readparams.F is already
> > in place so should be  straitforward.
> 
> In general, in which subroutine should I put a check for an outdated use of a #define X compile time parameter?  
> 
> In this case I'm renaming the SEAICE_SALINITY flag to SEAICE_VARIABLE_SALINITY but a check for an outdated use of SEAICE_SALINITY doesn't seem to naturally fit in either seaice_readparms.F or config_check.F.  The former only checks for run-time parameter sanity and the latter doesn't have any checks for outdated #define flags.
> 
> Thanks,
> Ian
>  
> 
> > 
> > Cheers,
> > Jean-Michel
> > 
> > On Tue, Apr 26, 2011 at 06:10:58PM -0700, Ian Fenty wrote:
> >> Hi Jean-Michel,
> >> 
> >> You are right, I left debugging output statements in my code when I
> >> generated the output*txt files and I didn't actually check in my
> >> comments to tag-index.
> >> 
> >> As you can tell, I'm still getting the hang of checking in code
> >> changes instead of working in my own private universe, please be
> >> patient while I figure it all out!
> >> 
> >> Step 2 is completed.  seaice_growth.F is updated and several
> >> verification output*txt files needed updating.
> >> 
> >> I'll do the variable renaming in Step 3, once Step 2 comes back as working.
> >> 
> >> -Ian
> >> 
> >> On 4/26/2011 8:45 AM, Jean-Michel Campin wrote:
> >>> Hi Ian,
> >>> 
> >>> I've made checkpoint62w half an hour ago (11.am EST) after updating
> >>> tag-index.
> >>> 
> >>> I had to check-in new output*.txt, see e.g.:
> >>> http://mitgcm.org/pipermail/mitgcm-cvs/2011-April/022714.html
> >>> because it seems you did not use a standard version of MITgcm,
> >>> and those funny lines in the output*.txt were making
> >>> few files bigger than they should be. e.g., in
> >>> verification/offline_exf_seaice/results, with 11520 funny lines:
> >>> -rw-r--r--. 1 jmc 964425 04-25 17:20 output.seaicetd.txt
> >>> and with standard code:
> >>> -rw-r--r--. 1 jmc 250162 04-26 11:39 output.seaicetd.txt
> >>> 
> >>> I did not see this (and I've checked):
> >>>> I documented the change in tag-index.
> >>> so I added my own words before the tag (so that it's
> >>> part of checkpoint62w).
> >>> 
> >>> You can go for step.2
> >>> 
> >>> Jean-Michel
> >>> 
> >>> 
> >>> On Tue, Apr 26, 2011 at 08:08:43AM -0700, Ian Fenty wrote:
> >>>> Jean-Michel,
> >>>> 
> >>>> Step 1 is complete and the testing passed last night and I
> >>>> documented the change in tag-index.  Shall I proceed to step 2 or
> >>>> would you like to checkpoint first?
> >>>> 
> >>>> Ian
> >>>> 
> >>>> On Mon, Jean-Michel wrote:
> >>>> 
> >>>> 
> >>>>> I prefer to group in step.1 the changes in data (rhoConstFresh)
> >>>>> and data.seaice (ICE2WATR + SEAICE_X values),
> >>>>> because this is all about getting better constants with the same code.
> >>>>> 
> >>>>> Then in step.2, changes in pkg/seaice/seaice_growth.F (to fix what
> >>>>> you spotted);
> >>>>> 
> >>>>> And renaming SEAICE_salinity (and/or SEAICE_VARIABLE_SALINITY) can be
> >>>>> put in setp.3, because it's always anoying to rename parameters which
> >>>>> are set in namelist (need to put them in "retired" list and
> >>>>> stop if they are found in data.seaice), and would need also to
> >>>>> stop if the old OPTION "SEAICE_SALINITY" is found to be defined.
> >>>>> 
> >>>>> But I don't know precisely when to do the checkpoint (I though
> >>>>> I would do it after step.1, but might see how thing are going).
> >>>>> 
> >>>>> Cheers,
> >>>>> Jean-Michel
> >>>> 
> >>>> _______________________________________________
> >>>> MITgcm-devel mailing list
> >>>> MITgcm-devel at mitgcm.org
> >>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> >>> _______________________________________________
> >>> MITgcm-devel mailing list
> >>> MITgcm-devel at mitgcm.org
> >>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> >> 
> >> 
> >> _______________________________________________
> >> MITgcm-devel mailing list
> >> MITgcm-devel at mitgcm.org
> >> http://mitgcm.org/mailman/listinfo/mitgcm-devel
> > 
> > _______________________________________________
> > MITgcm-devel mailing list
> > MITgcm-devel at mitgcm.org
> > http://mitgcm.org/mailman/listinfo/mitgcm-devel
> 
> 
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel