[MITgcm-devel] [MITgcm-cvs] MITgcm/pkg/seaice CVS Commit

[Martin Losch]

Hi Gael,

what a job you have done! Of course now I don't recognize anything in seaice_growth.F, but I will learn. Quick comments before I do so:

Obviously I could not convince you that the "vintage bug" really isn't one. How can you convince me? I guess we should ask Jinlun how to do it right. And then equivalent part for snow is treated differently ...

The part about "truncating" AREA is the simple "ridging scheme" of this model. Currently I do not see this happening in the part of the code that is used with SEAICE_GROWTH_LEGACY undefined. Instead somewhere in the beginning of the routine AREA is reset to AREAmax. I think that this should really happen at the end, because we must not leave seaice_growth with an AREA>1, does not make sense.
Also areaMax should be used in both parts of the code (and should become a runtime parameter).

I am curious to find out what you will do next. In the meantime I have not yet gotten around to finishing the verification experiment that we want to use for checking the budgets ... But I'll get there.

Martin

On Oct 15, 2010, at 9:10 PM, Gael Forget wrote:

> Update of /u/gcmpack/MITgcm/pkg/seaice
> In directory faulks.csail.mit.edu:/u/u2/gforget/MITgcm/pkg/seaice
> 
> Modified Files:
> 	seaice_growth.F 
> Log Message:
> 
> 
> Merging seaice_growth codes -- part 3 -- the merging, at last.
> 
> This check-in completes the overall 10/2010 revision and merging process, by
> 
> - adding a header that explains unit/sign/naming conventions.
> - introducing areaMax parameter that is, for now, hardcoded to 1.
> - re-including the 'vintage bug' as a comment -- in case I got it wrong.
> - bracketing 'IF (useRelativeWind)' with '#ifdef ALLOW_ATM_WIND'  
> consistent with what pkg/exf does.
> - merging the '_if.F' features that differ from what is in legacy code:
>  - option to actually grow ice over open water, which legacy code 
>    only virtually takes into account in the area tendency (I think).
>  - let melting by ocean reduce area (as melting by atm alone does in legacy).
>  - different criteria for rain->snow (incl. as comments).
> 
> The added features are bracketed out of legacy code, so this 
> revision did not affect forward results. A couple cosmetic modifications
> changed adjoint results by only three digits. I will only update those.
> 
> 
> 
> 
> _______________________________________________
> MITgcm-cvs mailing list
> MITgcm-cvs at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-cvs

Martin Losch
Martin.Losch at awi.de