[MITgcm-devel] profile package issues

[Matthew Mazloff]

Hello (Gael),

We are having two issues with the profile package

1) The flag set in profiles_interp (mask_cur) does not appear to be  
saved.  And in the profiles cost all that is considered is the  
observational weight.  So if an observation is taken but it is not a  
wet point for the model, there is a serious issue.  The prof_data1D  
will be non-zero, and the prof_traj1D wil be zero -- and there  
difference will be counted in the cost.  This leads to huge cost  
values, especially for salinity.

A quick fix would be to have a
if (prof_traj1D(K).NE.0.) statement on line 121 of cost_profiles.

2) The model values written for profiles with longitudes < XC(1) are  
being set to 0.  Though I cannot see in the code why this is...  I  
wonder if there is an issue with line 117 in profiles_interp:
         if (xG(i,j,bi,bj).LT.xG(1,j,bi,bj)) then
          lon_tmp1=xG(i,j,bi,bj)+360
          else
          lon_tmp1=xG(i,j,bi,bj)
          endif
Perhaps since lon_tmp1 is a lower bounds it should always just be set  
to lon_tmp1=xG(i,j,bi,bj) without the need for the IF statement.


What do people think?  These are minor issues but perhaps a major effect

Thanks,
Matt