[MITgcm-devel] vintage bug in seaice_growth.F ?

[Gael Forget]

Hi Martin,

as part of the seaice_growth.F merge process, I stumbled 
on something that looks odd. Either I am missing something, 
or it is a bug that dates back to the growth.F era...

It would be great if you could double-check my reading of  
seaice_growth.F V1.70 (the last one before my modifs):
------------------------------------------------------------
line 445	FICE is multiplied by area -> GHEFF becomes 'effective'
line 472	FICE is updated, dividing GHEFF by area -> FICE remains 'NOT effective'
=> I think this is correct.
------------------------------------------------------------
line 569	FICE is multiplied by area -> growthNeg becomes 'effective'
line 583	QNETI is defined, without area division -> QNETI is 'effective' too
line 778	as part of the QNETO/QNETI weighted average, 
	QNETI, which is already 'effective', is wrongly mutliplied by AREA
	QNETO, which is 'NOT effective', is correctly mutliplied by (1-AREA)
=> I think the double multiplication by area is wrong.
------------------------------------------------------------

Can you confirm that I should fix this? 
Or please tell me what I am missing.

Cheers,
Gael