[MITgcm-devel] ggl90_calc

[Jean-Michel Campin]

Hi Martin and David,

I look at S/R ggl90_calc.F (more precisely, to the implicit diffusion
of TKE) and noticed few thing that I don't like too much
(at least misleading, but some might also be more like a bugg).

It's all checked-in as comments in the code ("C- jmc:"):
> danton{ggl90}% egrep '^C- jmc:' ggl90_calc.F
> C- jmc: concerned about missing a deltaT since gTKE is already the future TKE.
> C- jmc: concerned that a(k=2) should always be zero 
> C- jmc: concerned that c(k) from k=kLow to k=Nr should always be zero
> C- jmc: this is dangerous since klowC could be zero if land column
> C- jmc: concerned about conservation when a or c are changed after computing b
> C- jmc: would be much better to update the provisional TKE (i.e. gTKE) at k=2
 
When you have time to look at this.

Cheers,
Jean-Michel