[MITgcm-devel] Re: [MITgcm-cvs] MITgcm/eesupp/inc CVS Commit

[Jean-Michel Campin]

Hi Patrick,

Your new version looks good to me (along the idea of a 
"private copy" of CPP_EEMACROS.h, but better).

just a little thing: do we want to put back the old _GLOBAL_MAX_R4 
and _GLOBAL_SUM_R4 (it's this one I tripped over the other day) 
within #ifdef USE_OLD_MACROS_R4R8toRSRL / #endif  block
so that we get all the old macros or do you prefer to drop those 2 ?

it used to be:
#ifdef REAL4_IS_SLOW
#define _GLOBAL_SUM_R4(a,b) CALL GLOBAL_SUM_R8 ( a, b)
#define _GLOBAL_MAX_R4(a,b) CALL GLOBAL_MAX_R8 ( a, b )
#else
#define _GLOBAL_SUM_R4(a,b) CALL GLOBAL_SUM_R4 ( a, b )
#define _GLOBAL_MAX_R4(a,b) CALL GLOBAL_MAX_R4 ( a, b )
#endif

Thanks,
Jean-Michel

On Sun, May 24, 2009 at 11:50:03PM -0400, Patrick Heimbach wrote:
>
> Hi Jean-Michel,
>
> not sure what you mean.
> In any case, it's not about keeping my private copy,
> but enabling various other groups who use the model
> to still be able to use older (e.g. working) packages
> along with more recent rest of the code.
>
> Cheers
> -Patrick
>
>
>
> On May 24, 2009, at 11:22 PM, Jean-Michel Campin wrote:
>
>> Hi Patrick,
>>
>> This looks great.
>> May be fixing those packages (a simple sed script would do it)
>> would not have been worst ?
>> Or keeping your private copy of CPP_EEMACROS.h somewhere ?
>> Now, just have to bet how long it will take to see
>> the use of mis-match macro coming back in repository ...
>>
>> Jean-Michel
>>
>> On Sun, May 24, 2009 at 12:57:49PM -0400, Patrick Heimbach wrote:
>>> Update of /u/gcmpack/MITgcm/eesupp/inc
>>> In directory forge:/tmp/cvs-serv8833
>>>
>>> Modified Files:
>>> 	CPP_EEMACROS.h
>>> Log Message:
>>> Restore some macros for package-wise backward compatibility.
>>>
>>> _______________________________________________
>>> MITgcm-cvs mailing list
>>> MITgcm-cvs at mitgcm.org
>>> http://mitgcm.org/mailman/listinfo/mitgcm-cvs
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>
> ---
> Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
> MIT | EAPS 54-1518 | 77 Massachusetts Ave | Cambridge MA 02139 USA
> FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach
>
>
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel