[MITgcm-devel] towards new tag

[Jean-Michel Campin]

Hi Patrick & Martin,

I have a question for you: It seems to me that
seaiceMaskU, seaiceMaskV are either fixed in time
(when SEAICE_maskRHS = F, = the default) or are recomputed at 
each time step (if SEAICE_maskRHS= T), in seaice_dynsolver.F

If we reset them to zero in seaice_model.F as it is done now 
(within #ifdef ALLOW_AUTODIFF_TAMC), then with SEAICE_maskRHS = F
(like in all the lab_sea AD tests), then will stay equal to zero 
and the seaice-dynamics will be trivial, no ? 

Waiting for your confirmation before tagging.

Cheers,
Jean-Michel

On Wed, Jun 24, 2009 at 04:45:15PM -0400, Jean-Michel Campin wrote:
> Hi,
> 
> I will pass a test on dickens (should not be too long) 
> and if everything is ok, will tag just after (so better
> not to check-in stuff before). And then Oliver could
> check-in the long_step stuff after.
> Cheers,
> Jean-Michel
> 
> PS: Martin, sorry, I did not see your 61q tag.
> 
> On Wed, Jun 24, 2009 at 04:32:30PM -0400, Patrick Heimbach wrote:
> >
> > I think it's all set.
> > Let's await the overnight verdict of testreport.
> >
> > It's noteworthy that gradient checks have improved by an order of  
> > magnitude
> > (gradients values remaining essentially the same).
> > So there likely was a slight bug in the previous adjoint code,
> > conceivably due to incomplete recomputations of the 3D entries
> > of the 3-time arrays.
> >
> > -p.
> >
> > Begin forwarded message:
> >
> >> From: Patrick Heimbach <heimbach at mitgcm.org>
> >> Date: June 24, 2009 4:26:43 PM EDT
> >> To: mitgcm-cvs at mitgcm.org
> >> Subject: [MITgcm-cvs] MITgcm/verification/lab_sea/results CVS Commit
> >> Reply-To: MITgcm-cvs at mitgcm.org
> >>
> >> Update of /u/gcmpack/MITgcm/verification/lab_sea/results
> >> In directory forge:/tmp/cvs-serv7115
> >>
> >> Modified Files:
> >> 	output_adm.txt
> >> Log Message:
> >>  Updating results following change of 3D to 2D arrays;
> >> Gradient checks have improved by an order of magnitude!
> >>
> >> _______________________________________________
> >> MITgcm-cvs mailing list
> >> MITgcm-cvs at mitgcm.org
> >> http://mitgcm.org/mailman/listinfo/mitgcm-cvs
> >
> > ---
> > Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
> > MIT | EAPS 54-1518 | 77 Massachusetts Ave | Cambridge MA 02139 USA
> > FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach
> >
> >
> > _______________________________________________
> > MITgcm-devel mailing list
> > MITgcm-devel at mitgcm.org
> > http://mitgcm.org/mailman/listinfo/mitgcm-devel
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel