[MITgcm-devel] Fwd: [MITgcm-cvs] MITgcm/doc CVS Commit

Patrick Heimbach heimbach at MIT.EDU
Tue Jun 23 13:56:52 EDT 2009


Hi Martin,

On Jun 23, 2009, at 12:16 PM, Martin Losch wrote:

> Hi Patrick,
> I do have now a working version (at least its passing the  
> verification experiments) where the 3D seaice fields are completely  
> removed. I will check it in, tomorrow that latest. I am just  
> waiting for JMCs confirmation, that I understand the seaice_read/ 
> write_pickup correctly.
>
> I think the major problem that I introduced is in advect.F: I  
> introduced a loop with length 2 to save some code for the modified  
> Euler time step (and the same for the obscure diffus calls),  
> similar to what I have done to seaice_lsr.F. If it's really a  
> problem that please go ahead an unroll the loops again. This part  
> of the code is not affected by the yet uncommited changes, but do  
> wait with this until I have checked in the rest.

OK, sounds good.
Is it an exact length 2, or is the loop length variable?

I'll wait until you've committed all the code and give me the go-ahead.

Cheers
-p.

> Martin
>
>
> On Jun 23, 2009, at 2:57 PM, Patrick Heimbach wrote:
>
>>
>> Hi Martin,
>>
>> I had thought you already have a local version of changed (3D ->  
>> 2D) code ready.
>> If not, maybe I should fix the adjoint first (but had hoped not  
>> having to do it twice).
>> Let me know.
>>
>> Cheers
>> -Patrick
>>
>> On Jun 23, 2009, at 2:54 AM, Martin Losch wrote:
>>
>>> Hi Patrich, not sure I can manage to do that today (too many  
>>> meetings and I am not feeling to well). Also I don't really know  
>>> how to do it right? Do I just replace the 3D fields by 2D fields  
>>> in the seaice_read/write_pickup.F and that works?
>>> I'll give it a shot asap.
>>>
>>> Martin
>>> PS. did I break the adjoint? Most likely in advect.F
>>>
>>> On Jun 22, 2009, at 9:19 PM, Patrick Heimbach wrote:
>>>
>>>>
>>>> Hi Martin,
>>>>
>>>> J.M. and I were wondering whether you are trying
>>>> to avoid some important work (hence lots of work on pkg/seaice)
>>>> ;o)
>>>>
>>>> Since you're 1/2 way through with code modif's it might now be best
>>>> to complete the changes by removing the 3D fields altogether,
>>>> and I'll try to catch up with the adjoint after it's all done.
>>>> What do you think?
>>>>
>>>> Cheers
>>>> -p.
>>>>
>>>> Begin forwarded message:
>>>>
>>>>> From: Martin Losch <mlosch at mitgcm.org>
>>>>> Date: June 22, 2009 11:58:42 AM EDT
>>>>> To: mitgcm-cvs at mitgcm.org
>>>>> Subject: [MITgcm-cvs] MITgcm/doc CVS Commit
>>>>> Reply-To: MITgcm-cvs at mitgcm.org
>>>>>
>>>>> Update of /u/gcmpack/MITgcm/doc
>>>>> In directory forge:/tmp/cvs-serv27539/doc
>>>>>
>>>>> Modified Files:
>>>>> 	tag-index
>>>>> Log Message:
>>>>> document first steps in cleaning up the 3-time levels of  
>>>>> UICE,VICE,HEFF,AREA:
>>>>> 1. introduce fields for time step (N-1 = *Nm1)
>>>>> 2. do not use levels 2 and 3 anymore (but they are still around)
>>>>>
>>>>> these changes probably break the adjoint, but the pickup is still
>>>>> working, so I am stopping now to give P. a chance to fix the  
>>>>> adjoint
>>>>> if necessary and then I will get rid of the 3D fields altogether
>>>>> carefully taking into account the pickup (not clear how).
>>>>>
>>>>> _______________________________________________
>>>>> MITgcm-cvs mailing list
>>>>> MITgcm-cvs at mitgcm.org
>>>>> http://mitgcm.org/mailman/listinfo/mitgcm-cvs
>>>>
>>>> ---
>>>> Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
>>>> MIT | EAPS 54-1518 | 77 Massachusetts Ave | Cambridge MA 02139 USA
>>>> FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach
>>>>
>>>>
>>>> _______________________________________________
>>>> MITgcm-devel mailing list
>>>> MITgcm-devel at mitgcm.org
>>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>>>
>>> _______________________________________________
>>> MITgcm-devel mailing list
>>> MITgcm-devel at mitgcm.org
>>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>>
>> ---
>> Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
>> MIT | EAPS 54-1518 | 77 Massachusetts Ave | Cambridge MA 02139 USA
>> FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach
>>
>>
>> _______________________________________________
>> MITgcm-devel mailing list
>> MITgcm-devel at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel

---
Patrick Heimbach | heimbach at mit.edu | http://www.mit.edu/~heimbach
MIT | EAPS 54-1518 | 77 Massachusetts Ave | Cambridge MA 02139 USA
FON +1-617-253-5259 | FAX +1-617-253-4464 | SKYPE patrick.heimbach





More information about the MITgcm-devel mailing list