[MITgcm-devel] PLOT_FIELD_XY in seaice_do_diags.F

[Dimitris Menemenlis]

I agree with all of Martin's suggestions.  I included plot_field_xy because it is sometimes useful for debugging.  Now that pkg/seaice is bug-free, plot_field_xy can be removed ;-).  D.

Dimitris Menemenlis
818-625-6498
-----Original Message-----
From: Martin Losch <Martin.Losch at awi.de>
Date: Monday, Jun 15, 2009 12:11 am
Subject: Re: [MITgcm-devel] PLOT_FIELD_XY in seaice_do_diags.F
To: "MITgcm-devel at mitgcm.org" <MITgcm-devel at mitgcm.org>Reply-To: "MITgcm-devel at mitgcm.org" <MITgcm-devel at mitgcm.org>

Hi Jean-Michel, Dimitris,

most of these questions go directoy to Dimitris. I hardly ever look at  
the plot_field_xy output, and certainly never (so far) in the seaice  
output. As far as I am concerned you can remove these calls and rename  
the subroutine.

I don't know about the tave-fields. I have never touched them (not  
even looked at them). Maybe it's time to retire the tave-pkg  
altogether? E.g. put a stop statement somewhere into to code saying:
"you are using outdated code. all of the functionality has been moved  
to pkg/diagnostics. pkg/tave will be removed in the near future", keep  
this for a while (maybe a few months) and then get rid off pkg/tave ?

M.



On Jun 12, 2009, at 4:50 PM, Jean-Michel Campin wrote:

> Hi Martin,
>
> I was going to simplify the MDS part of seaice_do_diags.F
> (by the way, can I rename it "seaice_output.F, to clarify that
> it has nothing to do with the diagnostics pkg ?) removing
> the temp arr copy (since we have pkg/rw routine that
> allow to write 1 level among several).
>
> Do you really use the PLOT_FIELD_XY output ? Personally, most of the
> time, when I have a problem, it's always to track a relative diff <  
> 10^-3
> and the alphabet is not helpful. The only reason why I could look
> at the PLOT_FIELD_XY output would be for the overlap, but in
> seaice_do_diags.F they are reset by EXCH call just before the plot.
> I can either remove all the PLOT_FIELD_XY from seaice_do_diags.F
> (so that I don't need the temp array anymore, except for MNC), or
> keep them (much more coding), but then I will not check that the
> changes are right for those PLOT_FIELD output.
>
> other unrelated question:
> Why all the 2D seaice time-ave fields are stored in 5 indices arrays ?
> (FUtave, EmPmRtave, QNETtave ...)
>
> Cheers,
> Jean-Michel
>
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel

_______________________________________________
MITgcm-devel mailing list
MITgcm-devel at mitgcm.org
http://mitgcm.org/mailman/listinfo/mitgcm-devel