[MITgcm-devel] changes in grid initialisation

[Jean-Michel Campin]

Hi,

I would like to make small changes in grid initialisation
(in initialise_fixed.F), and changes S/R names:

set_ref_state.F   : replacing ini_phiref.F 
                    + add anelastic rho factor definition
load_ref_files.F  : replacing ini_reference_state.F
  (was thinking of calling it "load_profiles" but given pkg/profiles ...)
and taken out of ini_vertical_grid.F : set_grid.F (or set_grid_factor.F)
  just to set the deep-atmosphere grid factor, but needs to be after
  computing phiref (deep-Atmosphere in P-coord).

with the following calling order:
C      |-- MON_INIT
C      |-- INI_GRID
C      |   -- LOAD_GRID_SPACING
         remove : INI_REFERENCE_STATE
C      |   -- INI_VERTICAL_GRID
C      |    / INI_CARTESIAN_GRID
C      |   /  INI_SPHERICAL_POLAR_GRID
C      |   \  INI_CURVILINEAR_GRID
C      |    \ INI_CYLINDER_GRID
C      |-- LOAD_REF_FILES (part of what is presently in ini_reference_state)
C      |-- INI_EOS
C      |-- SET_REF_STATE (replace ini_phiref , + anelastic factor)
C      |-- SET_GRID (_FACTOR) (just setting deep-atmosphere grid factors)
C      |-- INI_DEPTHS

ini_phiref.F already contains more than just phiref calculation
(reference stratification for Implicit IGW, reference state for 
 NH with P-coord) and adding the anelastic density factor,
it make sense to rename it: set_reference_state or shorter: set_ref_state
And the 2 others, set_grid & load_ref_files just need to move out
of ini_grid.F

suggestion for better names ?

Unrelated: changing FIND_RHO_SCALAR to return rho (instead of rho-rhoConst)
reason: we may want to change the definition of rhoAnomaly to be
        rho-rhoRef(k) instead of rho-rhoConst.

Any objection ?

Cheers,
Jean-Michel