[MITgcm-devel] Re: [MITgcm-cvs] MITgcm/pkg/cfc CVS Commit

[Martin Losch]

Hi Jean-Michel,
thanks for point this out again. I guess reminding people of good  
programming standards can't be  done often enough.
I apologize for my quick hacks. Hope they are fixed now (passed my  
tests).

Martin

On 6 Nov 2007, at 22:16, Jean-Michel Campin wrote:

> Hi developers,
>
> Those modifications made in cfc_fields_load.F
> are not fitting in our coding standard:
> I should be able to get the same results with useSEAICE=F,
> whether I compile this package or not.
> I checked with experiment cfc_example, and was not too
> surprised to see that it change completely the cfc
> statistics.
>
> And regarding EXF, we agree that we will also move in this direction,
> a logical flag is now available (useEXF, in PARAMS.h,
> always set to True when EXF pkg is compile)
> so that new code can be written to fit into the "standard".
>
> It's not only a matter a "standard": it's a very slippy road
> to let users believe that 1 pkg is off (here seaice) since
> usePKG is false, whereas in few places some #ifdef ALLOW_PKG
> is messing up the simulation.
>
> It's not very difficult to write "clean" pieces of code,
> might take slightly more time, but if for any reason the
> time is missing, even more time can be saved by not checking
> in "bad" pieces of code.
>
> No tag has been made since Oct 25, and it needs to be fixed before
> the next one, or will have to go back to previous version.
>
> Jean-Michel
>
> On Thu, Oct 25, 2007 at 09:14:41AM -0400, Martin Losch wrote:
>> Update of /u/gcmpack/MITgcm/pkg/cfc
>> In directory forge:/tmp/cvs-serv3937/pkg/cfc
>>
>> Modified Files:
>> 	cfc_fields_load.F
>> Log Message:
>> I want to use cfc with exf and seaice
>>
>> _______________________________________________
>> MITgcm-cvs mailing list
>> MITgcm-cvs at mitgcm.org
>> http://mitgcm.org/mailman/listinfo/mitgcm-cvs
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel