[MITgcm-devel] removing SEAICE_GET_FORCING ?

[Dimitris Menemenlis]

> It would be better to have a run-time parameter, yes.

OK.

> And I haven't look
> to those pieces of code, but It does not seem like we need lot of 
> extra arrays, so may be a CPP_OPTION is not necessary.
> If for some (TAF) reasons Patrick needs to hide some part of this code,
> could then add back a CPP_OPTION.

No extra arrays are needed.  Was mostly concerned about adding "IF's" for TAF.

> Should this run-time parameter be sitting in PARAMS.h ?
> I found that it would be more logical in EXF_PARAM.h (because 
> surface winds are part of exf, and the main code only knows about
> wind-stress ; also for coupled set-up, wind stress is computed separatly,
> sometime by the atmospheric model, and then turning this flag on/off 
> in the ocean model will have no effect).
> Is there a serious (or practical) reason to have is in PARAMS.h ?

I will need access to this flag in pkg/exf "and" in pkg/seaice.  So what is 
least of two evils?  If I put in EXF_PARAM.h, I will then need to include 
EXF_PARAMS.h in a seaice routines.  Let me know, which is preferred option.

> I have the same comment as Martin, and suggest that you don't copy those 
> fields but just add explicitly an #include EXF_FIELDS.h
> in all the seaice S/R that use it (and there should not be too many),
> rather than to have this #include EXF_FIELDS.h hiden in SEAICE_FFIELDS.h.

OK.

D.

-- 
Dimitris Menemenlis <menemenlis at sbcglobal.net>
5056 Oakwood Ave, La Canada, CA 91011-2450
tel/fax: 818-790-6735;   cell: 818-625-6498