[MITgcm-devel] Re: ggl90

[Martin Losch]

Hi David,

I fixed the array TKEtave and the output-stuff in ggl90_readparms  
(why did I put it there in the first place?).

I am not sure about the factor sqrt(2), too tired to check. If you  
are absolutely positive about that, change it.

M.

On Jun 7, 2006, at 12:35 PM, David Ferreira wrote:

> Martin Losch wrote:
>
>> Hi David,
>>
>> fixed the bug, was diving surface bc by 0 (GGL90mixingLength,  
>> which  is not computed for surface). Now this is fixed. Please  
>> update and  try again. And keep complaining.
>>
>> M.
>>
> Hi Martin,
>
> Thanks it is great!
> And since you are asking I will complain :
>
> 1) It seems that the code is broken now because of the  
> configuration lines
> that you put in ggl90_readparams.F.
> If I comment them out, the model runs fine ....
> Also, JMC tells me that the test reports are hanging on in the vermix
> experiment.
>
> 2) I think a factor sqrt(2) is missing in the computation of
> GGL90mixingLength (line 182-183) of ggl90_calc.F, compared to
> the equation (2.35) of Blanke and Delecluse.
>
> 3) the time averages of TKE and viscAr are wrong because GGL90TKEtave
> is declared as a 2d array in GGL90_DIAGS.h
>
> What do you think?
>
> Cheers, have a good travel.
>
> david
>
> -- 
>
> Ferreira David               Tel : 617 253 7967 EAPS Room 54-1515,
> Massachusetts Institute of Technology,
> 77 Massachusetts Avenue
> Cambridge, MA, 02139
>