[MITgcm-devel] global_with_exf fails

[Patrick Heimbach]

Hi Jean-Michel,

I saw this too yesterday, but didn't take it seriously
(I should have).

With the fix just checked in, the accuracy improves,
but stil fails.
Failing comes from the 2nd new block
        x_in(i) = mod(x_in(i),threeSixtyRL)
        if ( x_in(i) .lt. 0. )
     &   x_in(i) = threeSixtyRL+x_in(i)
which I think is correct
(and, for this experiment,
makes a difference in the overlap, doesn't it).

-p.



Quoting Jean-Michel Campin <jmc at ocean.mit.edu>:

> Hi Patrick,
>
> The modifications you made in exf_interp.F change the
> results of the global_with_exf test (it fails at level 2).
> Was it supposed to be like this (and then we need to update
> the output.txt), or is there something wrong ?
>
> Otherwise, i think there is a potential problem
> in mixing different type of argument (r8 & r4) in this call:
> line 91           xg(i,j,bi,bj) = mod(xg(i,j,bi,bj),360.)
> and in this one also:
> line114         x_in(i) = mod(x_in(i),360.)
> (xg is _RS and x_in is real*8)
> and it would be safer to use the same type of argument (e.g. with
> a _RS constant set to 360.  in the 1rst case and an other real*8
> constant set to 360. in the 2nd case).
>
> See you,
>
> Jean-Michel
>
>
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel
>



--------------------------------------------------------
Patrick Heimbach   Massachusetts Institute of Technology
FON: +1/617/253-5259                  EAPS, Room 54-1518
FAX: +1/617/253-4464             77 Massachusetts Avenue
mailto:heimbach at mit.edu               Cambridge MA 02139
http://www.mit.edu/~heimbach/                        USA