[MITgcm-devel] changes to exf_init_runoff.F

[Patrick Heimbach]

Dimitris,


On Dec 11, 2006, at 12:00 PM, Dimitris Menemenlis wrote:

> Patrick, I needed to be able to force model with monthly runoff so  
> I have removed exf_init_runoff.F and now deal with runoff in same  
> way as other atmospheric fields using exf_init and exf_set_gen

I saw your checkin.
Good idea to allow for time-varying runoff.
What I am confused about is that period=0 used to be reserved for  
monthly forcing.
Now that has changed?
If so, not a good idea to do that "in-the-middle-of-nowhere" (no tag,  
etc.)
because its impact is similar to changes of units,
but probably I'm just confused and all is ok.

I am actually not updating code currently since I am still struggling
with what's there now (prior to your latest exf changes).
At GFDL I am still not able to run v3 with newest code (NaN after few  
timesteps).
And newest code with v2 (i.e. no seaice, no bulk forcing) crashes  
after a
while (~ 2years or so) with cal error.
That same crash I now also get running arctic40km with latest code
(i.e. stop in cal package). No clue why.
I have abandoned the arctic run for now, until I am able to catch up  
with
everything that keeps changing in the code
(I have no clue how to actually get there currently).
I may come to ECCO meeting with pretty empty hands...

Re. your error message below,
seems simply that netcdf library is not found at compile time,
therfore it doesn't know about netcdf functions.
I just checked testing pages, and there the latest test passed.

Re. ALLOW_RUNOFF_CONTROL, nobody uses it currently,
so not to worry.

-p.

> One bit of code that I was not sure how to deal with is the  
> ALLOW_RUNOFF_CONTROL option, which used to live in  
> exf_init_runoff.F, and which now needs to be moved to  
> exf_getffields.F.  RUNOFF_CONTROL was set to operate on one time- 
> mean field only?  Does anybody use RUNOFF_CONTROL?  How should I  
> proceed?
>
> Dimitris
>
> P.S. verification/global_ocean_with_exf fails to compile, prior to  
> above change with following error messages.
>
>> [dimitri at glafkos build]$ make
>> g77 -Wimplicit -Wunused -mfpmath=sse -msse -msse2 -O0 -malign- 
>> double -c active_file_control_profiles.f
>> active_file_control_profiles.f: In subroutine  
>> `active_read_profile_rl':
>> active_file_control_profiles.f:1765:          err = NF_INQ_VARID 
>> (fid,prof_names(active_varnum), varid1 )
>>                ^
>> Invalid declaration of or reference to symbol `nf_inq_varid' at  
>> (^) [initially seen at (^)]
>> active_file_control_profiles.f:1766:          err =  
>> NF_GET_VARA_DOUBLE(fid, varid1 , vec_start, vec_count,
>>                ^
>> Invalid declaration of or reference to symbol `nf_get_vara_double'  
>> at (^) [initially seen at (^)]
>> active_file_control_profiles.f:1831:          err =  
>> NF_PUT_VARA_DOUBLE(fid, varid1 , vec_start, vec_count,
>>                ^
>> Invalid declaration of or reference to symbol `nf_put_vara_double'  
>> at (^) [initially seen at (^)]
>> In file included from active_file_control_profiles.f:0:
>> active_file_control_profiles.f:1736: warning: unused variable  
>> 'varid1'
>> active_file_control_profiles.f:1736: warning: unused variable 'err'
>> active_file_control_profiles.f: In subroutine  
>> `active_write_profile_rl':
>> active_file_control_profiles.f:3288:          err = NF_INQ_VARID 
>> (fid,prof_names(active_varnum), varid1 )
>>                ^
>> Invalid declaration of or reference to symbol `nf_inq_varid' at  
>> (^) [initially seen at (^)]
>> active_file_control_profiles.f:3289:          err =  
>> NF_PUT_VARA_DOUBLE(fid, varid1 , vec_start, vec_count,
>>                ^
>> Invalid declaration of or reference to symbol `nf_put_vara_double'  
>> at (^) [initially seen at (^)]
>> active_file_control_profiles.f:3298:          err = NF_PUT_VAR1_INT 
>> (fid, varid1 , vec_start(2),
>>                ^
>> Invalid declaration of or reference to symbol `nf_put_var1_int' at  
>> (^) [initially seen at (^)]
>> active_file_control_profiles.f:3347:          err =  
>> NF_GET_VARA_DOUBLE(fid, varid1 , vec_start, vec_count,
>>                ^
>> Invalid declaration of or reference to symbol `nf_get_vara_double'  
>> at (^) [initially seen at (^)]
>> active_file_control_profiles.f:3255: warning: unused variable  
>> 'varid1'
>> active_file_control_profiles.f:3255: warning: unused variable 'err'
>> make: *** [active_file_control_profiles.o] Error 1
> _______________________________________________
> MITgcm-devel mailing list
> MITgcm-devel at mitgcm.org
> http://mitgcm.org/mailman/listinfo/mitgcm-devel