[MITgcm-devel] new pkg/matrix checked in

[Jean-Michel Campin]

Hi Samar & Ed,

I had a quick look at matrix_example/code.
I have few comments regarding the replacement of the original
version (model/src, pkg/ptracers) with those modified files:

a) PARAMS.h is not up-to-date (Ed removed seaice_mdsio)

b) I would prefer to have a short S/R:
 MATRIX_OUTPUT (file = matrix_output.F )
with just 2 calls:
   if ( myIter.eq.nIter0 ) call matrix_write_grid
   if ( myIter.ne.nIter0 ) call matrix_write_tendency
and this S/R would be called from "do_the_model_io.F"
in place of call matrix_write_tendency.
And write_grid.F could be left unchanged.

c) the other thing is that I don't see clearly why you need to
 skip the ptracers output (in do_the_model_io) and not
 just set the proper output frequency to zero.

d) also for ptracers_init.F, what is the reason for setting
 tIter0=nIter0 and how can we do a correct restart with this ?
 And what about having tIter0 in data.ptracers ? will this
 fix your problem ?

e) ptracers_forcing_surf.F : is there a general reason to
 leave surfaceForcingPtr=0 or is it simply to avoid getting the
 salinity forcing ? (and in this 2nd case, I would keep this file
 in matrix_example/code)

f) regarding the 3 gad_dst3_adv_?.F , I would leave them in
 matrix_example/code for now (I would like to have Patrick's
 feedback on this piece of code)

Thanks,

Jean-Michel