[MITgcm-devel] barrier missing in CPP_OPTIONS.h

[Jean-Michel Campin]

Hi Ed,

I think we forget one (anoying) thing:
I don't see any "barrier" within CPP_OPTIONS.h

And the way the [PKG]_OPTIONS.h is done
(take for example LAND_OPTIONS.h :

> #ifndef LAND_OPTIONS_H
> #define LAND_OPTIONS_H
> #include "PACKAGES_CONFIG.h"
> #ifdef ALLOW_LAND
> 
> #include "CPP_OPTIONS.h"
> 
> C  allow time average diagnostic:
> #define ALLOW_LAND_TAVE
> 
> #endif /* ALLOW_LAND */
> #endif /* LAND_OPTIONS_H */

Does not prevent the double inclusion of CPP_OPTIONS.h,
like for instance in the S/R pkg/aim_v23/aim_land2aim.F

Whereas the old version of LAND_OPTIONS.h 
prevented the double inclusion :

> #ifndef _CPP_EEOPTIONS_H_
> #include "CPP_OPTIONS.h"
> #endif
> 
> #ifdef ALLOW_LAND
> 
> C  allow time average diagnostic:
> #define ALLOW_LAND_TAVE
> 
> #endif /* ALLOW_LAND */

It's a paint since we put back few "CPP_OPTIONS.h" that Alistair
didn't like.

Have a good night,
See you,

Jean-Michel